BugDay/200810

This page belongs to the TYPO3 Bug Day project (category Project)

Topic

Topic for this Bug Day is "ReviewDay", thus we're going to concentrate on patch reviews from the core list mainly.

Here is how it works:

• list pending bugs/features in the bugtracker
  • Pending patches in Gerrit for TYPO3 CMS Core
• look to the bug reports and pick an issue that sounds interesting to you
• Important: post the bug ID in IRC before you start working on it, so that nobody doues double work (the lists below show who is currently working on a specific issue)
• check if the bug/feature report still applies to current TYPO3 versions (Trunk/4.3 and 4.2)
• now the reviewing and testing process starts - so, search for the bug/feature ID in the TYPO3 Core List
• apply the provided patch file to your local TYPO3 installation and test if the patch solves the issue
• additionally you can also review the code and make sure if it's clean and understandable or has several programming flaws
• finally post your vote (+1 if everything was fine or -1 if something was wrong with an accordant description) to the TYPO3 Core List

If you didn't work on the TYPO3 Core List before, you'll find helpful information about the review process and communication here

This way we can track who did what - maybe there may be some prizes at some day for the most active Bug Day helpers.

Pending bugs in core list that are ready to commit

Name	Bug(s)
Christian Kuhn	19463: TYPO3 Core - Additional condition required to check SSL status in class.t3lib_div.php [Closed; assigned to Oliver Hader] No-brainer, can be commited right away
Oliver Hader	18781: TYPO3 Core - field tablename in sys_refindex too short [Closed; assigned to Rupert Germann] 19178: TYPO3 Core - Make simulate static a system extension [Closed; assigned to Benni Mack] Benni, your turn to commit v5! ;)
François Suter	19514: TYPO3 Core - TCEmain wrongly tests required input-type fields [Closed; assigned to Oliver Hader] 17742: TYPO3 Core - config.fileTarget for default link target on files [Closed; assigned to Jeff Segars]
Rob Vonk	16318: TYPO3 Core - Patch: new option TSFE.jumpUrl_prefer301 = 1 [Closed; assigned to Jeff Segars]

Reviewed bugs that need +1 from core member

Name	Bug(s)
François Suter	16806: TYPO3 Core - TCAdefaults.tt_content.imagecols = 1 is missing [Closed; assigned to Steffen Kamper] 17636: TYPO3 Core - config.prefixLocalAnchors = all destroys links in fe [Closed; assigned to Martin Kutschker] 18807: TYPO3 Core - Template Objectbrowser menu [Closed; assigned to Steffen Kamper]
Rob Vonk	18776: TYPO3 Core - In listview Clipboard icons are not in the viewport with 1024-resolution [Closed] (works like it (tested it) should but listview gets replaced in 4.3)
Christian Kuhn	17112: TYPO3 Core - Add file operation permissions for back-end user groups [Closed; assigned to Oliver Hader] Has several +1 from non core devs 18836: TYPO3 Core - Hardcoded labels in template module [typo3/sysext/tstemplate/ts] [Closed; assigned to Oliver Hader]
Sven Weiss	18999: TYPO3 Core - list title length fixed to 30 chars [Closed; assigned to Benni Mack] (related to 19358) 19358: TYPO3 Core - Setting the title len of items in web->list [Closed; assigned to Oliver Hader]

Working on these bugs

Name	Bug(s)
Rob Vonk
Francois Suter
Oliver Hader	17112: TYPO3 Core - Add file operation permissions for back-end user groups [Closed; assigned to Oliver Hader] 17636: TYPO3 Core - config.prefixLocalAnchors = all destroys links in fe [Closed; assigned to Martin Kutschker]
Jeff Segars

Patches that don't work / needs some work

Name	Bug(s)
Rob Vonk	18734: TYPO3 Core - SQL debug output is not shown in the Backend [Closed; assigned to Steffen Kamper] 18911: TYPO3 Core - Shortcut mode: add "parent page" [Closed; assigned to Steffen Gebert]
Daniel Krupke	17112: TYPO3 Core - Add file operation permissions for back-end user groups [Closed; assigned to Oliver Hader] (note: added new patch version, please retest. cheers christian)
Sven Weiss	18287: TYPO3 Core - Login-error or session timed-out - Missing translation [Closed; assigned to Benni Mack] (note: added a patch file in the bugtracker. perhaps it is exactly what we need here. greets sven)

Bugs that can be closed

Name	Bug(s)
Rob Vonk	17289: TYPO3 Core - Sitemap->SectionIndex with multilanguage [Closed; assigned to Ingo Renner] 16107: TYPO3 Core - Security breach --> possibility to hack system [Closed; assigned to Ingo Renner] 19174: TYPO3 Core - Little typo in setup part. Wrong target for sitemap in version 4.2.x [Closed; assigned to Ingo Renner] 15045: TYPO3 Core - FE Images are not displayed when processed through Imagemagick [Closed; assigned to Oliver Hader] 15099: TYPO3 Core - Tem,porary DB mount in Element Browser/RTE Link dialog [Closed; assigned to Oliver Hader] 15137: TYPO3 Core - Rename Cancel buttons to Close [Closed; assigned to Oliver Hader] 15154: TYPO3 Core - There are errors in the code [Closed]: errors in real old versions. Nice idea to test with new version though..
Marcus Krause	16347: TYPO3 Core - problem with prefixLocalAnchors [Closed; assigned to Ingo Renner] 18694: TYPO3 Core - config.prefixLocalAnchors = all destroys links when $scriptPath starts with a number [Closed; assigned to Ingo Renner]
François Suter	15296: TYPO3 Core - Cannot create new TS templates with Web>Template when others exist [Closed; assigned to Benni Mack] 18186: TYPO3 Core - Module Web > Template: enhance usability of docheader [Closed; assigned to Patrick Broens] 18057: TYPO3 Core - Menu items on 2 lines overlap in new backend [Closed]
Christian Kuhn	16408: TYPO3 Core - No unicode signs possible in title [Closed; assigned to Christian Kuhn] Unable to confirm, not reproducable, no feedback for a long time 16498: TYPO3 Core - Segfault when trying to create thumbnails in backend [Closed; assigned to Christian Kuhn] Not a TYPO3 issue 15520: TYPO3 Core - highlighting of module-headers on welcome-page [Closed; assigned to Oliver Hader] Already fixed 15578: TYPO3 Core - HTMLarea not wrapped correctly in "QuickEdit" view [Closed; assigned to Thomas Murphy] Probably fixed, note enough information, link to image broken 18186: TYPO3 Core - Module Web > Template: enhance usability of docheader [Closed; assigned to Patrick Broens] Already fixed 15296: TYPO3 Core - Cannot create new TS templates with Web>Template when others exist [Closed; assigned to Benni Mack] Already fixed 15154: TYPO3 Core - There are errors in the code [Closed] Very old, most probably not valid any longer, please open new issues is something is still valid 14763: TYPO3 Core - Create Files with no correkt umask when using with suphp [Closed] No feedback for long time 18082: TYPO3 Core - All TS coming after [usergroup=*] condition not working [Closed] Unable to reproduce 17435: TYPO3 Core - Setting [FE][lifetime] higher than one week, disables Login [Closed] Unable to reproduce 18837: TYPO3 Core - Missing dot in t3lib_TStemplate line 1377 [Closed] Close requested by reporter
Christopher	17934: TYPO3 Core - Is Options +FollowSymLinks needed in default _.htaccess file? [Closed] 19546: TYPO3 Core - Incorrect password field input value when editing Backend & Frontend users [Closed; assigned to Christian Kuhn] 16758: TYPO3 Core - typoscript editor too small in internet explorer 7 [Closed; assigned to Christian Kuhn] 17219: TYPO3 Core - update wizard incorrectly updates the compat_version [Closed; assigned to Christian Kuhn] has already been solved 15938: TYPO3 Core - missing higlighting in help/about aka welcome screen [Closed; assigned to Oliver Hader] is solved 15542: TYPO3 Core - Modules/sub-modules enabling/disabling via User->Task center [Closed; assigned to Christian Kuhn] Modules can be hidden; groups can be collapsed 15543: TYPO3 Core - Top drop-down menu [Closed; assigned to Oliver Hader] t3skin has already been changed completely and uses another concept now. 15405: TYPO3 Core - No styling of collapsed menu-items possible [Closed; assigned to Oliver Hader] 15118: TYPO3 Core - Install tool with Tabs [Closed; assigned to Chris topher] Install-Tool will be rewritten from scratch. 15390: TYPO3 Core - Bug in rich text editor with IE 6.0 [Closed; assigned to Christian Kuhn] Problem with very old and nowaydays unsupported version; not reproducable in current versions.

Old bugs that can't be reproduced

Name	Bug(s)
Christopher	16325: TYPO3 Core - Typo 3 4.0 and PHP5 issue? [Closed; assigned to Christian Kuhn] 17373: TYPO3 Core - TSFE : beUserLogin doesn't work, when config.baseUrl is set. [Closed; assigned to Benni Mack]

Usability issues that are still valid

Name	Bug(s)
Rob Vonk	14805: TYPO3 Core - FE user passwords shown in page module and info popup of list module [Closed]. Note that FE records can't be created on 'normal' pages so the page module bug isn't there. The password exposing bug in the infoscreen is still there 15105: TYPO3 Core - showpic.php does not resize the popup size if necessary [Closed]